Node editor - Native implementation of NodesIconsPanel addon code

Reiner's picture
Project: 
Bforartists Tracker

Now that the icons are natively available it's time to remove the Blender tabs in the Node Editor's Tool shelf. And implement the panels and tabs from the NodesIcons Panel addon natively into the Blender UI code. So that there is no addon required anymore.

Our solution uses three tabs, and you quickly find what you are looking for. The Blender solution uses 11 tabs, and you are at searching.

Status: 
Closed (fixed)
Priority: 
Normal
Category: 
Task
Component: 
User interface
Assigned: 
Images: 
Reporter: 
Created: 
Sun, 12/03/2017 - 11:21
Updated: 
Mon, 12/04/2017 - 13:11

Comments

6
Draise's picture

Yaaaaaasss, I am so looking forward to this.

Reiner's picture

Yes, it's a bit disturbing with all these tabs there I-m so happy

Reiner's picture

Assigned: Unassigned » Reiner
Reiner's picture

Holy crap. What a can of worms this code is -.-

Reiner's picture

Fixed in master

https://github.com/Bforartists/Bforartists/commit/c3f2eb5b60b084ca4ac796...

Not happy with the nasty thing that i had to do here. It's a dirty hack. But it works.

Normally you really disable everything connected and throw it out. But the whole native panel code is cluttered across several files and dozens of classes. And i couldn't exactly find what to disable without to break things. There is other functionality connected too. An excellent example of spaghetti code and how to not do it. And so i ended with disabling the three classes with the actual panels, while the rest of the code is still available and at work.

Maybe we can return to this at a later point, and clean it up a bit better. For now it's working ...

The nodes icons panel addon is completely removed. It has run its course.

Image: 
Reiner's picture

Status: Active » Closed (fixed)